Which directives (define / $conf array) from the config.inc.php file to use

Discussion in 'Developers' Forum' started by zigi, Mar 22, 2011.

  1. zigi

    zigi New Member

    Hi,

    I'm writing some patches but I don't know, which directives (define ~ constant / item of $conf array) from the config.inc.php file to use in modules, plugins etc. Which one is preffered?

    For example for server root exist three directives:
    1. define('ISPC_ROOT_PATH', realpath(dirname(__FILE__).'/../'));
    2. $conf['rootpath'] = substr(dirname(__FILE__),0,-4);
    3. define('SERVER_ROOT',$conf['rootpath']);

    I think that the code needs some cleaning.
     
  2. till

    till Super Moderator

    Please use the $conf array.

    Yes, thats indeed the case. A guy who originally wants to clean up things instead messed everything up and stopped at 50% of the changes and left us with this messy duplicate conf definitions.
     

Share This Page