Upgrade Idiot

Discussion in 'Installation/Configuration' started by ITI, Apr 3, 2017.

  1. ITI

    ITI New Member

    New installation went fairly smoothly.
    I saw there was an upgrade and followed the upgrade procedure.
    After spending and wasting hours of time trying to figure what went wrong, I figured out.
    The key word is "upgrade" so my question is:
    Is there some place to add custom settings to *.conf files such as pure-ftpd.conf that won't be overwritten when an upgrade is performed.
    Glen
     
  2. florian030

    florian030 ISPConfig Developer ISPConfig Developer

    copy the templates to /usr/local/ispconfig/server/conf-custom/install and change this file
     
  3. ITI

    ITI New Member

    It seems that I'm not quite getting it?
    I copied "/etc/pure-ftpd/pure-ftpd.conf" which has 2 custom settings to;
    "/usr/local/ispconfig/server/conf-custom/install/pure-ftpd.conf"
    I changed the ispconfig version number in config.inc.php and reran: ispconfig_update.sh
    "/etc/pure-ftpd/pure-ftpd.conf" was overwritten and my custom change gone!
    What did I miss?
     
  4. till

    till Super Moderator Staff Member ISPConfig Developer

    Florian said to copy the template of that file to the conf-custom folder and not the configuration file. The template is in the install/tpl/ folder of the ispconfig tar.gz file.
     
  5. ITI

    ITI New Member

    Thank you very much. It works :)
    So what happens if there is a major change, in this case to pure-ftpd and its default options?
    Would this be flagged during the update?

    Wouldn't it make more sense to append only the changes to the master file?
    This is how you more or less do it for individual websites.

    Thanks again
    Glen
     
  6. till

    till Super Moderator Staff Member ISPConfig Developer

    Then you have to adjust your config.

    No. When you are using a non standard setup then it's your task as admin to take care that your own config files are compatible with new ISPconfig and pure-ftpd versions.
     
  7. ITI

    ITI New Member

    Thanks for the reply's Till
    However, you didn't comment on my third point.
    "Wouldn't it make more sense to append only the changes to the master file?
    This is how you more or less do it for individual websites"
    If the template file only contained the changes and and these were appended to the new *.conf file, we would have the benefit of any new config options included in the new release.
    i.e. A current configuration on an on going basis.
    I hope this is viewed as constructive and not negative criticism.
     
  8. till

    till Super Moderator Staff Member ISPConfig Developer

    The master file is the config that is used on install and updates, so we need all configuration in the file at install time. Beside that, ispconfig supports it to skip intermediate updates, so basically we would have to create a master file for each release and subrelease which contains only the changes from one release to the other so we end up having dozens of master files just for this one service and have to compute an individual file for each specific case from them. I don't think that this is a viable alternative to allowing a custom configuration file as we have it now.

    I did not see your comments as criticism :)
     

Share This Page