troubleshooting vhost.conf.master

Discussion in 'Developers' Forum' started by charlesrg, Apr 29, 2010.

  1. charlesrg

    charlesrg New Member

    I'm having a problem that The Vhosts are not populated with the SSL Engine.

    Looking at vhost.conf.master I see it's doing a check like:
    <tmpl_if name='ssl_enabled'>

    Do you guys know how can I debug this section of the code. I would like to see why ssl_enabled is not coming up.
     
  2. charlesrg

    charlesrg New Member

    Okay I see I'm on my own

    So here is the issue:

    As ISPCONFIG 3.0.2.1 there is a bug in apache2_plugin.inc.php

    When Ispconfig is checking for the Certificate files it checks based on
    domain not on ssl_domain. So that's why for some people SSL works but when someone goes and check www.domain.com as their SSL Domain the system falls appart.


    DEVELOPERS PLEASE UPDATE apache2_plugin.inc.php and vhost.conf.master

    Here is my patch generated with diff
    diff -dir /usr/local/ispconfig/server/conf/vhost.conf.master /root/ispconfig3_install/server/conf/vhost.conf.master
    187c187
    < ServerName <tmpl_var name='ssl_domain'>
    ---
    > ServerName <tmpl_var name='domain'>
    206,207c206,207
    < SSLCertificateFile <tmpl_var name='document_root'>/ssl/<tmpl_var name='ssl_domain'>.crt
    < SSLCertificateKeyFile <tmpl_var name='document_root'>/ssl/<tmpl_var name='ssl_domain'>.key
    ---
    > SSLCertificateFile <tmpl_var name='document_root'>/ssl/<tmpl_var name='domain'>.crt
    > SSLCertificateKeyFile <tmpl_var name='document_root'>/ssl/<tmpl_var name='domain'>.key
    209c209
    < SSLCACertificateFile <tmpl_var name='document_root'>/ssl/<tmpl_var name='ssl_domain'>.bundle
    ---
    > SSLCACertificateFile <tmpl_var name='document_root'>/ssl/<tmpl_var name='domain'>.bundle

    diff -dir /usr/local/ispconfig/server/plugins-available/apache2_plugin.inc.php /root/ispconfig3_install/server/plugins-available/apache2_plugin.inc.php
    160c160
    < $domain = $data["new"]["ssl_domain"];
    ---
    > $domain = $data["new"]["domain"];
    177c177
    < $domain = $data["new"]["ssl_domain"];
    ---
    > $domain = $data["new"]["domain"];
    307a308
    > //print_r($data);
    543a545
    >
    551d552
    < $vhost_data["ssl_domain"]=$data["new"]["ssl_domain"];
    561c562
    < $domain = $data["new"]["ssl_domain"];
    ---
    > $domain = $data["new"]["domain"];
    565c566
    <
    ---
    >
     
    Last edited: Apr 30, 2010
  3. till

    till Super Moderator Staff Member ISPConfig Developer

    Thanks for the fix. I will upload it to svn
     
  4. vogelor

    vogelor ISPConfig Developer ISPConfig Developer

    IT'S Done ;-)
     

Share This Page