Should changing Apache Directives also trigger FPM pool reload?

Discussion in 'Developers' Forum' started by choong, Apr 7, 2020.

  1. choong

    choong New Member

    When changing Apache Directives it is possible to also modify the FPM pool since everything is handled by the same plugin. If I add a directive like:

    SetEnv PHP_VALUE "doc_root = /web/current/web"

    I need the FPM pool to be reloaded. Would you guys agree that changing Apache Directives should also trigger restartPHP_FPM? If so, I am happy to send a PR.
     
  2. Jesse Norell

    Jesse Norell ISPConfig Developer ISPConfig Developer

    Changing php version/mode/settings should reload trigger php daemon reloads, there's no reason to reload php if all you are changing is for the web server.

    Offhand, what are you trying to accomplish? Setting an environment variable for your web server will not propagate to the php daemon, as they are completely separate, communicating only over a socket.
     
  3. till

    till Super Moderator Staff Member ISPConfig Developer

    I agree to what @Jesse Norell wrote, in my opinion, changes in apache should not reload fpm daemon.
     
  4. choong

    choong New Member

    Thanks, you are right. Somehow I thought I had run into a problem with what I was trying to accomplish, but I am now unable to reproduce the problem. Disregard this thread.
     

Share This Page