Implemented new features. Request to commit.

Discussion in 'Developers' Forum' started by LaKing, Mar 8, 2011.

  1. LaKing

    LaKing New Member


    Okay, for my own purposes I implemented the following 'features':

    * SSL certificate signing with a custom CA as default. (not delf-signed)
    This is approx. 4 lines of code, not a big deal.

    * SSH Public Key authentication
    This is several lines of code in several files (interface, server and also requires new fields in SQL.)
    When a new user is created, the server generates the private and public key, that can be obtained in the Tools section. When creating a new shell-user, the user's public key, and an additional optional custom key is added to the shell user's authorised keys, thus allowing logging in without typing a password.

    There are two options. I can post all modifications here to the forum as code, so the main developers can review them, and apply them in the next release, or I can add them myself to the svn, to some beta-branch.

    Please advise :) ...

    István Király
  2. till

    till Super Moderator Staff Member ISPConfig Developer

    Are these new options configurable in system > server config so that they can be disabled by default and dont change the current behaviour of existing installs?
  3. LaKing

    LaKing New Member

    Not yet, but I can implement that.

    Lets say, a CA-path into the system configuration->web tab, empty by default for self signing certificates. And an additional CA-signing password might be necessary.

    For public key authentication, a new tab might be necessary unless we want to handle ssh-access in one tab, in that case the jailkit tab shuld be renamed to 'ssh'-tab, and there should be two sections, ssh and ssh-jailkit.

    Also, the installer/updater scripts need to be updated. ...

    I can do all that if you want to have it in the official release. ...
  4. till

    till Super Moderator Staff Member ISPConfig Developer

    That would be great!


    I think that renaming is a good idea as we dont have that much space for new tabs.


    I guess it can be integrated into 3.0.4. As the next release is a bugfix release.

    Please upload your changes to SVN trunk. If you dont have a password yet, please send me an email to dev [at] ispconfig [dot] org.

Share This Page