How can I contribute?

Discussion in 'Developers' Forum' started by RealOpty, Nov 8, 2013.

  1. RealOpty

    RealOpty New Member

    Hello,
    I would like to get on the development team. I have experience with PHP. Id like to help by working on the feature requests.
     
  2. Croydon

    Croydon ISPConfig Developer ISPConfig Developer

    You can register an account at the git repository and fork the ISPConfig repository. When you created something you can send a merge request and the code will be reviewed.
     
  3. RealOpty

    RealOpty New Member

  4. Croydon

    Croydon ISPConfig Developer ISPConfig Developer

  5. RealOpty

    RealOpty New Member

    Thanks! Quite a lot of activity lately :)

    Soon ill be sending merge requests!:cool:
     
  6. Disassembler

    Disassembler New Member

    Hi Marius,

    nice to see ISPconfig is using git now! However, I'm having problems signing up, the verification mail never arrived and according to my server logs there hasn't even been a corresponding delivery attempt. Could you check what's going on with m+ispconfig at towiski dot de?
    I found a bug in the daemon restarting module that I'd like to commit.
     
  7. till

    till Super Moderator Staff Member ISPConfig Developer

    Thanks for signung up on our git server. I will heck what happened with your email.
     
  8. till

    till Super Moderator Staff Member ISPConfig Developer

    @Disassembler: I guess it might have been a issue with our spf record, I missed to add our git server. Did you receive the email for your second account?
     
  9. florian030

    florian030 ISPConfig Developer ISPConfig Developer

    maybe you can add a few notes about the general git-handling to the registration-mails or the workflow-page?

    something like this:

    Set you identity
    cd YOUR_GIT_DIR
    git config --global user.name "YOUR NAME"
    git config --global user.email [email protected]
    git remote set-url origin [email protected]:YOURNAME/ispconfig3.git

    Keep your fork up-to-date
    clone your fork: git clone http://git.ispconfig.org/YOUR_NAME/ispconfig3.git
    cd to the fork (cd ispconfig3)
    git remote add upstream http://git.ispconfig.org/ispconfig/ispconfig3.git
    git fetch upstream
    git pull upstream master

    Submit changes
    git add *
    git commit
    git push origin master

    Get stable 3.0.5
    git clone http://git.ispconfig.org/ispconfig/ispconfig3.git
    cd ispconfig3
    git checkout stable-3.0.5

    Check code for errors
    find . -name "*.php" -exec php -l {} \; | grep -v 'No syntax e'
     
  10. till

    till Super Moderator Staff Member ISPConfig Developer

    Thanks for the commands! I've planned to a add developer and getting started infos on a page on ispconfig.org, I will add this info there plus a ink in the welcome emails.
     
  11. Croydon

    Croydon ISPConfig Developer ISPConfig Developer

    Just an addition:
    Submitting is easier using
    Code:
    git commit -a
    git push
    No need for "git add" if there were only changed files, its only needed for newly created ones.
     
  12. Disassembler

    Disassembler New Member

    Hi Till,

    no, I didn't see any connection attempt, neither from 144.76.136.121 nor anything with ispconfig in its name. SPF is only a small factor in my Spamassassin so that can't be it. I thought I might have to do with the plus-addressing that some people's "address correctness" rules reject so I tried the second account but no luck either. I reckon there must be stuff in the mail queue on the git machine.
     
  13. till

    till Super Moderator Staff Member ISPConfig Developer

    I checked the mailqueue already, there is nothing in it. Your accounts are shown as active, have you tried to login with one of them?
     
  14. Disassembler

    Disassembler New Member

    Yup, just tried again. "diassembler" gives me an error saying, expectedly, "You must confirm your account before continuing", "mbethke" justs says "invalid email or password". Same if I use the corresponding addresses instead of a user name.
     
  15. till

    till Super Moderator Staff Member ISPConfig Developer

    I've send you new login details by email.
     
  16. Disassembler

    Disassembler New Member

    Thank you, Till, that worked fine!
    I'll see if I can get a fix for the rescue module committed before I have to go offline for a week :)
     
  17. Disassembler

    Disassembler New Member

    Hm, seems somehow I'm too thick to use GitLab. It's not that I can't use git and I've also set up gitolite with all the bells and whistles, but the only thing I get out of GitLab is:
    Code:
    $ git clone [email protected]:mbethke/ispconfig-3.git
    Cloning into 'ispconfig-3'...
    Access denied.
    fatal: The remote end hung up unexpectedly
    The URL is what GitLab gives me. The SSH keys are installed. "ssh -vT [email protected]" works:
    Code:
    [blah]
    debug1: Authentication succeeded (publickey).
    Authenticated to git.ispconfig.org ([144.76.136.121]:22).
    [more blah]
    Welcome to GitLab, Matthias Bethke!
    debug1: client_input_channel_req: channel 0 rtype exit-status reply 0
    debug1: client_input_channel_req: channel 0 rtype [email protected] reply 0
    debug1: channel 0: free: client-session, nchannels 1
    Transferred: sent 3304, received 2448 bytes, in 3.4 seconds
    Bytes per second: sent 982.4, received 727.9
    debug1: Exit status 0
    
    So GitLab lets me in, recognizes my key, and then doesn't let me clone the project I just forked and that I'm the only member (and thus implicitly admin, I assume) of?
     
  18. florian030

    florian030 ISPConfig Developer ISPConfig Developer

    There must be something wrong with your setup. I can clone your fork without any problems:

    Code:
    git clone http://git.ispconfig.org/mbethke/ispconfig3.git
    Cloning into 'ispconfig3'...
    remote: Counting objects: 70216, done.
    ...
     
  19. Disassembler

    Disassembler New Member

    OK, I just found HTTP access works for me as well, the problem is just with SSH. I didn't know GitLab supported pushes via TTP so I'd only tried SSH to be able to actually push stuff back. A full checkout takes ages from my slow line here but I just tried on my server and committing seems to work too. It would just be nice if the server supported HTTPS so as not to keep sending clear-text passwords around the world.
     
  20. till

    till Super Moderator Staff Member ISPConfig Developer

    I use ssh checkouts with git.ispconfig.org only and did not had any problems with that yet. I will see if I can find something in the logs.
     

Share This Page