Having domain name in php-fpm pool

Discussion in 'Installation/Configuration' started by grungy, Dec 16, 2013.

  1. grungy

    grungy Member

    I run sites with php-fpm in ISPConfig. Usually when I manually configure a php-fpm pool, I put the domain name in the pool name. Therefore when I run

    Code:
    rainbow:~# ps aux | grep "php-fpm: pool"
    
    I immediately know to what site a pool belongs to.

    I tried this:

    Code:
    # cp /usr/local/ispconfig/server/conf/php_fpm_pool.conf.master /usr/local/ispconfig/server/conf-custom/
    # nano /usr/local/ispconfig/server/conf-custom/php_fpm_pool.conf.master
    
    and I modified the first line in php_fpm_pool.conf.master to this:

    Code:
    [<tmpl_var name='fpm_pool'>-<tmpl_var name='domain'>]
    
    but I guess the <tmpl_var name='domain'> variable is not available for php-fpm template.
     
  2. grungy

    grungy Member

  3. grungy

    grungy Member

  4. Croydon

    Croydon ISPConfig Developer ISPConfig Developer

    If you want to have your patch included into the main ISPConfig repository, please make a merge request from your fork to the master branch.
     
  5. grungy

    grungy Member

    excuse me for asking , I am new to git, but how do I make a merge request?
     
  6. grungy

    grungy Member

  7. Croydon

    Croydon ISPConfig Developer ISPConfig Developer

    You have to do a merge request from YOUR project.
    There you can select the parent project as merge target.
     
  8. grungy

    grungy Member

    Under target project I only have my own project.
     
  9. Croydon

    Croydon ISPConfig Developer ISPConfig Developer

    It seems you have NOT done a fork of the ISPConfig main project.
    So you cannot create a merge request.

    To contribute you have to go to the ISPConfig repository and klick "fork".
    Then you can make changes to the forked repository and create a merge request from there.
     
  10. grungy

    grungy Member

    Yes I did fork it...
     
  11. Croydon

    Croydon ISPConfig Developer ISPConfig Developer

    Then something must have gone wrong as your repository is not marked as a fork.
     

Share This Page