Current (minor) bugs with SVN ~$3282

Discussion in 'Developers' Forum' started by cfoe, Jul 17, 2012.

  1. cfoe

    cfoe ISPConfig Developer

    1. Difference between:
    (from dns_soa_list.php)
    PHP:
    $app->uses('listform_actions');
    // $app->listform_actions->SQLExtWhere = "access = 'REJECT'";

    $app->listform_actions->SQLOrderBy 'ORDER BY origin';
    $app->listform_actions->onLoad();
    and
    (from web_domain_list.php)
    PHP:
    $app->load('listform_actions');

    $list = new list_action;
    $list->SQLExtWhere "type = 'vhost'";
    $list->SQLOrderBy 'ORDER BY domain';
    $list->onLoad();
    both is "doing" the same. Which version is preferred?

    2. Error on client_edit page:

    If you are on the "Limits" page and try to switch to "Address" via the tab (or click on the "limits" tab) ->
    output of the "DB::query(INSERT..." in the frontend. The data will successfully be inserted into the db.

    Can you reproduce the error?

    3. Is the globalsearch looking for domains in the domain module? On my dev machine it does not.
     
  2. till

    till Super Moderator

    1) The second form should only be used if the class has to be extended e.g. when a subfunction must be overwritten. In all other cases I would prefer the short form (1).

    2) Maybe some fields in your databaseare missing in the database scheme on your test system. have you added the bank account fields that have been added lately?

    3) The domain module is not included yet as it gets removed before the 3.0.5 release. The functionality is included in the client module as the function of the domain module is a cleint limit and it should not have been a separate module.
     
  3. cfoe

    cfoe ISPConfig Developer

    ????:confused:

    There seems to be something awry on my dev machine.

    Sounds good. Maybe you could consider removing some headlines in the sites module menu by combining some pages. There are so many cats with just one site. For smaller resolutions height is very limited. I often forget that not all users have displays with a 2560x1440 resolution. :cool:
     
  4. till

    till Super Moderator

    In most cases the version from dns_soa_list.php can be used as it does not require to create a new object. But sometimes it is nescessary to create a new object to override subfunctions, in that case the version from web_domain_list.php is better. Both versions have the same functionality, so I dont thint that its nescessary to edit the existing files.

    I add a feature request for that in the bugtracker.
     

Share This Page