Change to sieve_filter.master template causes all mail moved to Junk

Discussion in 'Developers' Forum' started by basmevissen, Apr 7, 2021.

  1. basmevissen

    basmevissen New Member

    Yes, I'm still running my ancient mail server. As it is still on ESM, it is maintained and secure.
    After the latest update (3.2.4) and making larger change to the email filters, I noticed all mail got delivered to the Junk folder.
    I found out that this is because of the following part of commit https://git.ispconfig.org/ispconfig/ispconfig3/-/commit/1157b9b249792dd46bc2617a4f25c7f5e183e07a
    This breaks my setup as the X-Spam-Status header looks like this:
    The "YES" in BAYES is matching the case sensitive check done by sieve:
    The fix is to make this test case sensitive:
    Please review this fix and make it part of the next release. I manually altered the template file and the affected sieve file.
    (note: one can edit the sieve file and just remove the svbin file, the latter is automatically recreated.

    This concludes a long evening of hacking :)
    Cheers,

    Bas.
    (who learned a lot about debugging Sieve files now :))
     
  2. Jesse Norell

    Jesse Norell ISPConfig Developer Staff Member ISPConfig Developer

    Thanks for the report. Another option would be a positional match, eg.
    Code:
    if header :matches ["X-Spam", "X-Spam-Flag", "X-Spam-Status"] "Yes*" {
    
    Or
    Code:
    if anyof (header :is ["X-Spam", "X-Spam-Flag"] "YES", header :matches "X-Spam-Status" "Yes, *") {
    
    https://git.ispconfig.org/ispconfig/ispconfig3/-/issues/6146
     
  3. basmevissen

    basmevissen New Member

    Many thanks for the quick response. There are many ways to fix this issue, so please just take the one you find the most appropriate.
    Hope to see the fix soon in a release!
     
  4. Th0m

    Th0m ISPConfig Developer Staff Member ISPConfig Developer

    It will be fixed in 3.2.5.
     

Share This Page