Bugs in the code of the ISPConfig software

Discussion in 'Installation/Configuration' started by vaio1, May 17, 2008.

  1. vaio1

    vaio1 ISPConfig Developer

    Hi guys,

    I have some problem with ISPConfig software.

    • If I try to open the login.php I cannot see the image logo.
    • Inside the left frameset of the phpmyadmin -> phpNotice: ob_flush() [ref.outcontrol]: failed to flush buffer. No buffer to flush. in /home/admispconfig/ispconfig/web/phpmyadmin/libraries/ob.lib.php on line 116
    • The requested URL /<br /><b>Notice</b>: Undefined index: reseller in <b>/home/admispconfig/ispconfig/web/login.php</b> on line <b>60</b><br />design/default/images/login_logo.png was not found on this server.
    • after the login page: Notice: Undefined variable: sessionispconfig in /home/admispconfig/ispconfig/web/login/trylogin.php on line 43 Warning: Cannot modify header information - headers already sent by (output started at /home/admispconfig/ispconfig/web/login/trylogin.php:43) in /home/admispconfig/ispconfig/web/login/trylogin.php on line 55

    Other errors:
    Code:
    Notice: Undefined index: sessionispconfig in /home/admispconfig/ispconfig/lib/classes/ispconfig_auth.lib.php on line 79
    
    Notice: Use of undefined constant icon - assumed 'icon' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 36
    
    Notice: Use of undefined constant title - assumed 'title' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 37
    
    Notice: Use of undefined constant link - assumed 'link' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 38
    
    Notice: Use of undefined constant perms - assumed 'perms' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 39
    
    Notice: Use of undefined constant icon - assumed 'icon' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 42
    
    Notice: Use of undefined constant title - assumed 'title' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 43
    
    Notice: Use of undefined constant link - assumed 'link' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 44
    
    Notice: Use of undefined constant perms - assumed 'perms' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 45
    
    Notice: Use of undefined constant icon - assumed 'icon' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 48
    
    Notice: Use of undefined constant title - assumed 'title' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 49
    
    Notice: Use of undefined constant link - assumed 'link' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 50
    
    Notice: Use of undefined constant perms - assumed 'perms' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 51
    
    Notice: Use of undefined constant icon - assumed 'icon' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 53
    
    Notice: Use of undefined constant title - assumed 'title' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 54
    
    Notice: Use of undefined constant link - assumed 'link' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 55
    
    Notice: Use of undefined constant perms - assumed 'perms' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 56
    
    Notice: Use of undefined constant icon - assumed 'icon' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 58
    
    Notice: Use of undefined constant title - assumed 'title' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 59
    
    Notice: Use of undefined constant link - assumed 'link' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 60
    
    Notice: Use of undefined constant perms - assumed 'perms' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 61
    
    Notice: Use of undefined constant icon - assumed 'icon' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 63
    
    Notice: Use of undefined constant title - assumed 'title' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 64
    
    Notice: Use of undefined constant link - assumed 'link' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 65
    
    Notice: Use of undefined constant perms - assumed 'perms' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 66
    
    Notice: Use of undefined constant deck - assumed 'deck' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 96
    
    Notice: Use of undefined constant shortText - assumed 'shortText' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 97
    
    Notice: Use of undefined constant longText - assumed 'longText' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 98
    
    Notice: Use of undefined constant imageField - assumed 'imageField' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 99
    
    Notice: Use of undefined constant linkField - assumed 'linkField' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 100
    
    Notice: Use of undefined constant doubleField - assumed 'doubleField' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 101
    
    Notice: Use of undefined constant integerField - assumed 'integerField' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 102
    
    Notice: Use of undefined constant dateField - assumed 'dateField' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 103
    
    Notice: Use of undefined constant fileField - assumed 'fileField' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 104
    
    Notice: Use of undefined constant attachField - assumed 'attachField' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 105
    
    Notice: Use of undefined constant descField - assumed 'descField' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 106
    
    Notice: Use of undefined constant seperatorField - assumed 'seperatorField' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 107
    
    Notice: Use of undefined constant checkboxField - assumed 'checkboxField' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 108
    
    Notice: Use of undefined constant optionField - assumed 'optionField' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 109
    
    Notice: Use of undefined constant pluginField - assumed 'pluginField' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 110
    
    Notice: Use of undefined constant messageField - assumed 'messageField' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 111
    
    Notice: Use of undefined constant workflowField - assumed 'workflowField' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 112
    
    Notice: Use of undefined constant terminField - assumed 'terminField' in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 113
    
    Notice: Undefined index: template_root in /home/admispconfig/ispconfig/web/isp_manager/lib/module.inc.php on line 120
    
    Notice: Undefined property: go_api::$debug in /home/admispconfig/ispconfig/lib/session.inc.php on line 248
    
    Notice: Undefined index: web_id in /home/admispconfig/ispconfig/web/index.php on line 41
    
    Notice: Undefined variable: getstring in /home/admispconfig/ispconfig/web/index.php on line 45
    
    What is happening?
    Thanks
     
    Last edited: May 17, 2008
  2. till

    till Super Moderator

    These are no bugs, you just set the error warning level in PHP wrong. Please set it to report just errors and no notices.
     
  3. vaio1

    vaio1 ISPConfig Developer

    Hi Till,

    the /root/ispconfig/php/php.ini file has been set in this way:
    Code:
    error_reporting  =  E_ALL 
    I cannot change the main settings of the error_reporting because my projects needs it. However, is there a way to set it only for the ISPConfig project?

    Furthermore, why ISPConfig has not every variables checked?
    For instance, I can see in the code of the login.php file that the line #32 is not written correctly.

    PHP:
    $err intval($_GET["err"]);
    instead of
    PHP:
    $err = (!empty($_GET["err"]) && is_numeric($_GET["err"])) ? intval($_GET["err"]) : 0;
    I would like to help you as web developer but I have tried some difficulty to update my online version to the last svn version of ISPConfig.

    thanks
     
  4. falko

    falko Super Moderator

    That php.ini is only for ISPConfig and does not effect the web sites that run on the main Apache.
     
  5. vaio1

    vaio1 ISPConfig Developer

    Hi Falko,

    the problem persists with: error_reporting = E_ALL & ~E_NOTICE

    Notice: Undefined variable: sessionispconfig in /home/admispconfig/ispconfig/web/login/trylogin.php on line 43
     
    Last edited: May 18, 2008
  6. vaio1

    vaio1 ISPConfig Developer

    Hi guys,

    the ISPConfig has no control for every variable:

    These are only few error in the index.php page.
    Code:
    Notice: Undefined index: tree_id in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 35
    
    Notice: Undefined index: gid in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 38
    
    Notice: Undefined index: userid in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 39
    
    Notice: Undefined index: form in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 41
    
    Notice: Use of undefined constant main - assumed 'main' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 398
    
    Notice: Use of undefined constant table - assumed 'table' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 399
    
    Notice: Use of undefined constant stylesheet - assumed 'stylesheet' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 400
    
    Notice: Use of undefined constant TITLE - assumed 'TITLE' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 406
    
    Notice: Use of undefined constant SESSION - assumed 'SESSION' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 407
    
    Notice: Use of undefined constant BACKGROUND_GIF - assumed 'BACKGROUND_GIF' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 408
    
    Notice: Use of undefined constant COPYRIGHT - assumed 'COPYRIGHT' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 409
    
    Notice: Use of undefined constant FGCOLOR - assumed 'FGCOLOR' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 410
    
    Notice: Use of undefined constant TABLE_H_COLOR - assumed 'TABLE_H_COLOR' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 411
    
    Notice: Use of undefined constant WINDOWTITLE - assumed 'WINDOWTITLE' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 412
    
    Notice: Use of undefined constant SITENAME - assumed 'SITENAME' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 413
    
    Notice: Use of undefined constant DESIGNPATH - assumed 'DESIGNPATH' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 414
    
    Notice: Use of undefined constant CHARSET - assumed 'CHARSET' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 415
    
    Notice: Use of undefined constant SERVERURL - assumed 'SERVERURL' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 416
    
    Notice: Use of undefined constant NEXT_TREE_ID - assumed 'NEXT_TREE_ID' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 417
    
    Notice: Undefined variable: next_tree_id in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 417
    
    Notice: Use of undefined constant CALLER_TREE_ID - assumed 'CALLER_TREE_ID' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 418
    
    Notice: Undefined variable: caller_tree_id in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 418
    
    Notice: Use of undefined constant S - assumed 'S' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 419
    
    Notice: Use of undefined constant TARGET - assumed 'TARGET' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 420
    
    Notice: Undefined variable: form_target in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 421
    
    Notice: Undefined variable: deck_id in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 485
    
    Notice: Use of undefined constant DOCTYPE_TITLE - assumed 'DOCTYPE_TITLE' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 496
    
    Notice: Use of undefined constant DOCTYPE_DESCRIPTION - assumed 'DOCTYPE_DESCRIPTION' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 497
    
    Notice: Use of undefined constant WINDOWTITLE - assumed 'WINDOWTITLE' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 498
    
    Notice: Use of undefined constant GROUP_ID - assumed 'GROUP_ID' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 499
    
    Notice: Use of undefined constant TREE_ID - assumed 'TREE_ID' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 500
    
    Notice: Use of undefined constant BOXSIZE - assumed 'BOXSIZE' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 501
    
    Notice: Use of undefined constant DECK_ID - assumed 'DECK_ID' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 502
    
    Notice: Use of undefined constant DOC_ID - assumed 'DOC_ID' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 503
    
    Notice: Use of undefined constant DOCTYPE_ID - assumed 'DOCTYPE_ID' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 504
    
    Notice: Use of undefined constant NEXT_DOCTYPE_ID - assumed 'NEXT_DOCTYPE_ID' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 505
    
    Notice: Undefined variable: next_doctype_id in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 505
    
    Notice: Use of undefined constant WYSIWYG_LIB - assumed 'WYSIWYG_LIB' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 506
    
    Notice: Undefined variable: checkform in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 651
    
    Notice: Undefined variable: deck1 in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 669
    
    Notice: Undefined variable: deck2 in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 673
    
    Notice: Undefined property: pluginField::$value in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 698
    
    Notice: Undefined variable: html_out in /home/admispconfig/ispconfig/lib/plugins/check_uptime.plugin.php on line 52
    
    Notice: Undefined variable: buffer in /home/admispconfig/ispconfig/lib/plugins/check_uptime.plugin.php on line 56
    
    Notice: Undefined variable: hlp in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 719
    
    Notice: Undefined property: pluginField::$value in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 698
    
    Notice: Undefined variable: html_out in /home/admispconfig/ispconfig/lib/plugins/check_disk.plugin.php on line 51
    
    Notice: Undefined variable: buffer in /home/admispconfig/ispconfig/lib/plugins/check_disk.plugin.php on line 55
    
    Notice: Undefined variable: hlp in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 719
    
    Notice: Use of undefined constant GROUPS - assumed 'GROUPS' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 770
    
    Notice: Undefined variable: groups in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 770
    
    Notice: Use of undefined constant GID_OLD - assumed 'GID_OLD' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 771
    
    Notice: Undefined variable: gid_old in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 771
    
    Notice: Use of undefined constant ELEMENTS - assumed 'ELEMENTS' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 772
    
    Notice: Use of undefined constant DECKS - assumed 'DECKS' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 773
    
    Notice: Use of undefined constant BUTTONS - assumed 'BUTTONS' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 774
    
    Notice: Use of undefined constant CHECKFORM - assumed 'CHECKFORM' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 775
    
    Notice: Use of undefined constant STYLESHEET - assumed 'STYLESHEET' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 777
    
    Notice: Use of undefined constant stylesheet - assumed 'stylesheet' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 777
    
    Notice: Use of undefined constant MAIN - assumed 'MAIN' in /home/admispconfig/ispconfig/web/multidoc/edit/edit.php on line 778
    
    I have tried to debug it but it's full of unchecked variables.
    Which is the php.ini file called by the apache?

    Regards
     
  7. till

    till Super Moderator

    Set the error reporting in the file /root/ispconfig/php/php.ini to report only errors, no notices or warnings and then restart ispconfig.

    You should never change this php.ini, it is used only by ISPConfig and it is set to the right settings by default, so there is no need to touch this file.

    The php programming language changed over the years, some of the ispconfig 2 code is even from php3 so it is normal that it may trow some notices, this is normal and totaly uncritical.
     
  8. vaio1

    vaio1 ISPConfig Developer

    Hi Till,

    thank you for your assistance. I have tried to debug it but I need to understand how can I update my version of ISPConfig and start to help the project with my sparetime.

    Thanks
     
  9. falko

    falko Super Moderator

    Download the latest ISPConfig version, uncompress it, and then run
    Code:
    cd install_ispconfig
    ./setup
     
  10. vaio1

    vaio1 ISPConfig Developer

    I have an existing version installed in my server.
    Which is the newer version? the 2 or the 3?
    I don't want stop my server services.

    thanks
     
  11. till

    till Super Moderator

    Which is the exact version number that you have installed at the moment?
     
  12. vaio1

    vaio1 ISPConfig Developer

    I suppose the 2.2.15 because in the config file there is this line: $go_info["server"]["version"] = "2.2.15";

    thanks
     
  13. till

    till Super Moderator

  14. vaio1

    vaio1 ISPConfig Developer

    Ok, the setup is secure? Can I trust of it? :p
    thanks
     
  15. till

    till Super Moderator

    Thats the setup that everyone here uses to update its their ISPConfig versions.

    To be on the safe side, make a backup of /root/ispconfig, /home/admispconfig (with preserved permissions) and the ispconfig database before you update. In case of an error, just copy back your backup.
     
  16. vaio1

    vaio1 ISPConfig Developer

    Ok I am trying to update it. I am praying! ;)
     

Share This Page