About FS_DIV

Discussion in 'Developers' Forum' started by jwarnier, Sep 24, 2010.

  1. jwarnier

    jwarnier ISPConfig Developer ISPConfig Developer

    I would like to bring attention to the FS_DIV constant and $conf['fs_div'] configuration object.
    While reviewing files, I first tried to get them used where they should have been, before realizing their uselessness.

    They are actually never used, and I honestly doubt they will be someday, as the only system where it could be of any use is Windows, which couldn't be supported without a complete redesign of ISPConfig anyway.

    Worst: those fs_div are currently not (yet) used everywhere they should, so it makes them really useless.

    Should we do something about them?
    Leave them as is, or rip them off anytime we are working on a file using them?
     
  2. till

    till Super Moderator Staff Member ISPConfig Developer

    I think we can remove them.

    The interface part is working fine and used on windows, thats why it has been intriduced. Also all the non linux service specific part of the server part works on windows mostly on windoes, there are just no server pluginsfor windows services available yet. But as PHP on windows is smart enough to work with Linux "/" as well, we can remove the variables. In case that there might be any windows plugins or ports in future, we might introduce specific settings for these plugins then.
     
  3. jwarnier

    jwarnier ISPConfig Developer ISPConfig Developer

    So, from now on, when I find one by chance in server/ or install/, I will remove it. I will leave the other ones (from interface/) for the time being.
     

Share This Page