PHP 5.4 problems

[xaver]

Hello,

i tested 5.4 a little bit and got some errors:

PHP Code:

Strict Standards:  Non-static method SimplePie_Misc::parse_date() should not be called statically, assuming $this from incompatible context in /usr/local/ispconfig/interface/lib/classes/simplepie.inc.php on line 60

Strict Standards:  Non-static method SimplePie_Parse_Date::get() should not be called statically, assuming $this from incompatible context in /usr/local/ispconfig/interface/lib/classes/simplepie.inc.php on line 10870 


i fixed some notice errors

regards
xaver

[till]

Have you tried to define both methods as static?

[xaver]

No, but i will look into it.

I fixed some other PHP 5.4 Notice Errors.
e.g.
if $conf['country'] is not defined and $conf = array() is defined it will drop an notice error if you use $conf['country']
i did s small if..
(isset($conf['country']) ? $conf['country'] : '')

[till]

I guess that there is a wrong variable used, the country settings in ISPConfig are in the variable $conf['language'] and not $conf['country'] (there is no separate contry setting available, so replacing the variable should fix the error.

[xaver]

Its in client and reseller in list. (My last commit)
Also i think it was readData witch had an error with readData['demo_viewmode']
or
Notice: Undefined variable: maintenance_mode_error in /usr/local/ispconfig/interface/web/login/index.php on line 238

Looks like each array element need a "isset() && condition(e.g. == != > <= ...)" the possibility exists its not set, because the element will be created.

I turned two functions into static functions and it looks like it works.

[till]

Notice: Undefined variable: maintenance_mode_error in /usr/local/ispconfig/interface/web/login/index.php on line 238

I fixed that in svn and changed the country setting to language.

[xaver]

Originally Posted by brian1999

Its in client and reseller in list.

Sorry. i dont understand.

[till]

This was a spam post, I removed that now. I edited your post and removed the spam link that you quoted with his message

[xaver]

Oh i saw no link, maybe blocked by my Browser and addons.

i will commit simplepie with static functions. Looks like it works fine.

can you take a look at commit 3011? fixed a lot of stuff for php 5.4. (+ i think small bug -> see comment)

Last know errors are at FAQ management, but i think the problem is of the wrong use of list/template system.

mail_transport_edit and mail_user_edit have a lot of @. That is bad because if a real problem comes around you won't see it.

[till]

i will commit simplepie with static functions. Looks like it works fine.

Thanks!

can you take a look at commit 3011? fixed a lot of stuff for php 5.4. (+ i think small bug -> see comment)

Looks fine Thanks for fixing the php notices.

Last know errors are at FAQ management, but i think the problem is of the wrong use of list/template system.

I guess we should consider to rewrite the faq module so that it uses the trmaplt system correctly. Might be cleaner then building workarounds to get the sorting functions to work with the current code.

mail_transport_edit and mail_user_edit have a lot of @. That is bad because if a real problem comes around you won't see it.

That should be changed in the long term indeed. I made a todo item in the bugtracker.