#1  
Old 24th September 2010, 23:43
jwarnier jwarnier is offline
Member
 
Join Date: Jan 2008
Location: Brussels, Belgium
Posts: 34
Thanks: 5
Thanked 0 Times in 0 Posts
Default About FS_DIV

I would like to bring attention to the FS_DIV constant and $conf['fs_div'] configuration object.
While reviewing files, I first tried to get them used where they should have been, before realizing their uselessness.

They are actually never used, and I honestly doubt they will be someday, as the only system where it could be of any use is Windows, which couldn't be supported without a complete redesign of ISPConfig anyway.

Worst: those fs_div are currently not (yet) used everywhere they should, so it makes them really useless.

Should we do something about them?
Leave them as is, or rip them off anytime we are working on a file using them?
Reply With Quote
Sponsored Links
  #2  
Old 24th September 2010, 23:51
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 37,015
Thanks: 840
Thanked 5,652 Times in 4,461 Posts
Default

I think we can remove them.

The interface part is working fine and used on windows, thats why it has been intriduced. Also all the non linux service specific part of the server part works on windows mostly on windoes, there are just no server pluginsfor windows services available yet. But as PHP on windows is smart enough to work with Linux "/" as well, we can remove the variables. In case that there might be any windows plugins or ports in future, we might introduce specific settings for these plugins then.
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
  #3  
Old 25th September 2010, 00:05
jwarnier jwarnier is offline
Member
 
Join Date: Jan 2008
Location: Brussels, Belgium
Posts: 34
Thanks: 5
Thanked 0 Times in 0 Posts
 
Default

Quote:
Originally Posted by till View Post
I think we can remove them.

The interface part is working fine and used on windows, thats why it has been intriduced. Also all the non linux service specific part of the server part works on windows mostly on windoes, there are just no server pluginsfor windows services available yet. But as PHP on windows is smart enough to work with Linux "/" as well, we can remove the variables. In case that there might be any windows plugins or ports in future, we might introduce specific settings for these plugins then.
So, from now on, when I find one by chance in server/ or install/, I will remove it. I will leave the other ones (from interface/) for the time being.
Reply With Quote
Reply

Bookmarks

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +2. The time now is 06:10.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2014, vBulletin Solutions, Inc.