Maildir creation in the latest ISPConfig3 SVN

[george_yohng]

Hello,

Looks like maildir creation script in the latest ISPConfig3 SVN is broken for the fact, that it adds too many apostrophes.

In addition to a normal maildir, I have a such peculiar folder structure inside /root home directory:

'
'/var
'/var/vmail
'/var/vmail/mydomain1.com
'/var/vmail/mydomain1.com/test
'/var/vmail/mydomain1.com/test/Maildir
'/var/vmail/mydomain1.com/test/Maildir/.Trash'
'/var/vmail/mydomain1.com/test/Maildir/.Trash'/tmp
'/var/vmail/mydomain1.com/test/Maildir/.Trash'/new
'/var/vmail/mydomain1.com/test/Maildir/.Trash'/cur
'/var/vmail/mydomain1.com/test/Maildir/.Junk'
'/var/vmail/mydomain1.com/test/Maildir/.Junk'/tmp
'/var/vmail/mydomain1.com/test/Maildir/.Junk'/new
'/var/vmail/mydomain1.com/test/Maildir/.Junk'/cur
'/var/vmail/mydomain1.com/test/Maildir/.Sent'
'/var/vmail/mydomain1.com/test/Maildir/.Sent'/tmp
'/var/vmail/mydomain1.com/test/Maildir/.Sent'/new
'/var/vmail/mydomain1.com/test/Maildir/.Sent'/cur
'/var/vmail/mydomain1.com/test/Maildir/.Drafts'
'/var/vmail/mydomain1.com/test/Maildir/.Drafts'/tmp
'/var/vmail/mydomain1.com/test/Maildir/.Drafts'/new
'/var/vmail/mydomain1.com/test/Maildir/.Drafts'/cur
'/var/vmail/mydomain1.com/test/Maildir/courierimapsubscribed'
'/var/vmail/mydomain1.com/test/Maildir/subscriptions'
'/var/vmail/mydomain1.com/test/Maildir'
'/var/vmail/mydomain1.com/test/Maildir'/tmp
'/var/vmail/mydomain1.com/test/Maildir'/new
'/var/vmail/mydomain1.com/test/Maildir'/cur
'/var/vmail/maildomain.com
'/var/vmail/maildomain.com/test
'/var/vmail/maildomain.com/test/Maildir
'/var/vmail/maildomain.com/test/Maildir/.Trash'
'/var/vmail/maildomain.com/test/Maildir/.Trash'/tmp
'/var/vmail/maildomain.com/test/Maildir/.Trash'/new
'/var/vmail/maildomain.com/test/Maildir/.Trash'/cur
'/var/vmail/maildomain.com/test/Maildir/.Junk'
'/var/vmail/maildomain.com/test/Maildir/.Junk'/tmp
'/var/vmail/maildomain.com/test/Maildir/.Junk'/new
'/var/vmail/maildomain.com/test/Maildir/.Junk'/cur
'/var/vmail/maildomain.com/test/Maildir/.Sent'
'/var/vmail/maildomain.com/test/Maildir/.Sent'/tmp
'/var/vmail/maildomain.com/test/Maildir/.Sent'/new
'/var/vmail/maildomain.com/test/Maildir/.Sent'/cur
'/var/vmail/maildomain.com/test/Maildir/.Drafts'
'/var/vmail/maildomain.com/test/Maildir/.Drafts'/tmp
'/var/vmail/maildomain.com/test/Maildir/.Drafts'/new
'/var/vmail/maildomain.com/test/Maildir/.Drafts'/cur
'/var/vmail/maildomain.com/test/Maildir/courierimapsubscribed'
'/var/vmail/maildomain.com/test/Maildir/subscriptions'

I can imagine that the maildir path is escaped one time too many when being passed to the actual directory creating utility.

Thanks,
George.

[george_yohng]

Despite this, bare maildirs (without Drafts/Sent/Junk/Trash) also seem to be created at the proper location (by dovecot?) and mail functions properly. 'courierimapsubscribed' is not created in the proper location, but this file is probably not needed (dovecot is used and configured).

[till]

Thanks for the bugreport. I've fixed that in svn.

[george_yohng]

Just a short note - on another test server I also found /root/'/var/backup' folder. I don't know, if this is related, or a separate place to be fixed.

[till]

Thats a separate problem. I will take a look at the sources.

[jwarnier]

Originally Posted by till

Thanks for the bugreport. I've fixed that in svn.

Actually, it was due to a series of bugs I introduced while removing exec() calls where escapeshellarg() was used instead of escapeshellcmd().

My bad, sorry for that.