Remoting : Adding a site (ISPConfig + TheHostingTool Integration)

[jmontoya]

It works well, but I move the datarecord and id before the plugin is loaded SVN:1919

Did you have a web access to the svn? Only for see/check the code?

[till]

The change you made to move the code that raises the event into the if($app->remoting_lib->formDef["db_history"] == 'yes') { part is not correct in my opinion as the event raising does not depend on the fact is history is enabled or not. Events have to be raised independantly of the history setting of the form. It should be moved outside of the if statement again. Othewise the plugins will not work correctly for forms weher dbhistory is not enabled.

The other changes moving the

$this->id = $insert_id;
$this->dataRecord = $params;

lines are ok.

Did you have a web access to the svn? Only for see/check the code?

No. I use a GUI based svn client.

[jmontoya]

I just change the order of:

$this->id = $insert_id;
$this->dataRecord = $params;

i dont know which line are you talking about:

The change you made to move the code that raises the event into the if($app->remoting_lib->formDef["db_history"] == 'yes') { part is not correct in my opinion as the event raising does not depend on the fact is history is enabled or not. Events have to be raised independantly of the history setting of the form. It should be moved outside of the if statement again. Othewise the plugins will not work correctly for forms weher dbhistory is not enabled.

[till]

Ok, youre right. I've just seen that these were just formatting changes.

[jmontoya]

I sent the plugin here SVN commit 1922

[jmontoya]

My bad, I'm creating a new thread for the new functions in the remoting class:

http://www.howtoforge.com/forums/sho...d.php?p=235575

[till]

Looks ok. I'am not sure if we should use separate functions for *_active and *_inactive, instead we might use a *_status or *_set_status function with active or inactive as parameter? What do you think?

[jmontoya]

yes I'm ok with the *_set_status('active') and *_set_status('inactive')
I will send this to the SVN.

[holykim]

Hi Till

Which file needs to be updated to resolve this issue?

I have updated remoting.inc.php which I got from svn today but sites_web_domain_add function seems not working properly. Do I need to update another files?

Another issue is when I remotely updated a client using client_update function in remoting.inc.php, this updated username and password for both client and Admin. (Administrator's username and password are replaced with a client's username and password)

I found that the below line1 changed to line2.

line1 (3.0.2.2):
$affected_rows = $this->updateQuery('../client/form/client.tform.php', $reseller_id, $client_id, $params);

line2 (svn):
$affected_rows = $this->updateQuery('../client/form/client.tform.php', $client_id, $reseller_id, $params);

Just swapped client_id and reseller_id. Why? I had no errors with the above line1.


Thanks in advance.

Harry

[ispcomm]

I wonder if there's any update on this integration ?

Any help needed in coding?

ispcomm