Go Back   HowtoForge Forums | HowtoForge - Linux Howtos and Tutorials > ISPConfig 3 > Developers' Forum

Do you like HowtoForge? Please consider supporting us by becoming a subscriber.
Reply
 
Thread Tools Display Modes
  #1  
Old 17th July 2012, 10:37
cfoe cfoe is offline
ISPConfig Developer
 
Join Date: Oct 2011
Location: NRW, Germany
Posts: 233
Thanks: 27
Thanked 57 Times in 32 Posts
Send a message via Skype™ to cfoe
Default Current (minor) bugs with SVN ~$3282

1. Difference between:
(from dns_soa_list.php)
PHP Code:
$app->uses('listform_actions');
// $app->listform_actions->SQLExtWhere = "access = 'REJECT'";

$app->listform_actions->SQLOrderBy 'ORDER BY origin';
$app->listform_actions->onLoad(); 
and
(from web_domain_list.php)
PHP Code:
$app->load('listform_actions');

$list = new list_action;
$list->SQLExtWhere "type = 'vhost'";
$list->SQLOrderBy 'ORDER BY domain';
$list->onLoad(); 
both is "doing" the same. Which version is preferred?

2. Error on client_edit page:

If you are on the "Limits" page and try to switch to "Address" via the tab (or click on the "limits" tab) ->
output of the "DB::query(INSERT..." in the frontend. The data will successfully be inserted into the db.

Can you reproduce the error?

3. Is the globalsearch looking for domains in the domain module? On my dev machine it does not.
__________________
Christian Foellmann

OpenSource-Projects - GitHub-Projects - SVN-Mirrors on GitHub - Foe Services
Reply With Quote
Sponsored Links
  #2  
Old 17th July 2012, 11:46
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 34,567
Thanks: 791
Thanked 4,979 Times in 3,900 Posts
Default

1) The second form should only be used if the class has to be extended e.g. when a subfunction must be overwritten. In all other cases I would prefer the short form (1).

2) Maybe some fields in your databaseare missing in the database scheme on your test system. have you added the bank account fields that have been added lately?

3) The domain module is not included yet as it gets removed before the 3.0.5 release. The functionality is included in the client module as the function of the domain module is a cleint limit and it should not have been a separate module.
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
  #3  
Old 17th July 2012, 20:56
cfoe cfoe is offline
ISPConfig Developer
 
Join Date: Oct 2011
Location: NRW, Germany
Posts: 233
Thanks: 27
Thanked 57 Times in 32 Posts
Send a message via Skype™ to cfoe
Default

Quote:
Originally Posted by till View Post
1) The second form should only be used if the class has to be extended e.g. when a subfunction must be overwritten. In all other cases I would prefer the short form (1).
????

Quote:
2) Maybe some fields in your databaseare missing in the database scheme on your test system. have you added the bank account fields that have been added lately?
There seems to be something awry on my dev machine.

Quote:
3) The domain module is not included yet as it gets removed before the 3.0.5 release. The functionality is included in the client module as the function of the domain module is a cleint limit and it should not have been a separate module.
Sounds good. Maybe you could consider removing some headlines in the sites module menu by combining some pages. There are so many cats with just one site. For smaller resolutions height is very limited. I often forget that not all users have displays with a 2560x1440 resolution.
__________________
Christian Foellmann

OpenSource-Projects - GitHub-Projects - SVN-Mirrors on GitHub - Foe Services
Reply With Quote
  #4  
Old 18th July 2012, 10:45
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 34,567
Thanks: 791
Thanked 4,979 Times in 3,900 Posts
 
Default

Quote:
????
In most cases the version from dns_soa_list.php can be used as it does not require to create a new object. But sometimes it is nescessary to create a new object to override subfunctions, in that case the version from web_domain_list.php is better. Both versions have the same functionality, so I dont thint that its nescessary to edit the existing files.

Quote:
Sounds good. Maybe you could consider removing some headlines in the sites module menu by combining some pages. There are so many cats with just one site. For smaller resolutions height is very limited. I often forget that not all users have displays with a 2560x1440 resolution.
I add a feature request for that in the bugtracker.
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
Reply

Bookmarks

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
rkhunter warnings esezako General 7 27th September 2011 07:28
Hacked server Captain Installation/Configuration 8 23rd December 2010 10:39
rkhunter report Captain Installation/Configuration 6 10th October 2010 13:05
Webmin upgrade lishaw1968 Installation/Configuration 15 26th August 2010 15:23
adding mail boxes kwickcut Server Operation 20 11th August 2010 01:02


All times are GMT +2. The time now is 12:48.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2014, vBulletin Solutions, Inc.