New way to handle co-domain rewrite + bugfix of apache directives

[Norman]

I propose a change of how rewrites are added by changing it so it doesnt do:

RewriteCond %{HTTP_HOST}   ^testdomain\.xh\.se [NC]
RewriteRule   ^/(.*)$  http://bigfoot.xh.se/forward/to/this/dir/$1  [R]

Instead it should do:

RewriteCond    %{HTTP_HOST}  ^testdomain\.xh\.se
RewriteRule    ^(.*)$        /var/www/webID/web/forward/to/this/dir/$1 [L]

What this would do is simply create co-domains with true paths.
http://testdomain.xh.se
instead of
http://otherdomain.xh.se/forward/to/this/dir/

This would not pose a security threat as I see it.

If the old style behaviour is wanted, then it should have a separate forward option.


Also, I do not know if this is per design. But when changing apache directives it seems to be stripping out backslashes when the apache directive is read from database back to the client. Saving again will cause the backslashes to be removed.

RewriteCond %{HTTP_HOST}   ^testdomain\.xh\.se [NC]
RewriteRule   ^/(.*)$  http://bigfoot.xh.se/forward/to/this/dir/$1  [R]

would become

RewriteCond %{HTTP_HOST}   ^testdomain.xh.se [NC]
RewriteRule   ^/(.*)$  http://bigfoot.xh.se/forward/to/this/dir/$1  [R]

Edit... The bug I noted seems to be related and already reported at http://www.howtoforge.com/forums/showthread.php?t=907

[falko]

Originally Posted by Norman

Edit... The bug I noted seems to be related and already reported at http://www.howtoforge.com/forums/showthread.php?t=907

We will check that.

[Norman]

What do you think about the rewrite proposal?
Is it unthinkably stupid?

[falko]

Originally Posted by Norman

What do you think about the rewrite proposal?
Is it unthinkably stupid?

We had some issues with this kind of forward (but I can't remember trhem anymore... ), that's why we changed it to how it is working now...

[Norman]

Are there any logs of the issues?

The ispconfig template seems to strip out {} and \ so I've bypassed this by adding it to apache directives as an include.