Go Back   HowtoForge Forums | HowtoForge - Linux Howtos and Tutorials > ISPConfig 3 > Installation/Configuration

Do you like HowtoForge? Please consider supporting us by becoming a subscriber.
Reply
 
Thread Tools Display Modes
  #1  
Old 16th September 2009, 17:02
Rescue9 Rescue9 is offline
Member
 
Join Date: Jun 2007
Posts: 52
Thanks: 4
Thanked 3 Times in 2 Posts
Default Newline fails in Mailfilter now.

Aaarrrrggghhh.....
System: Perfect Server Ubuntu 9.04 setup Fully upgraded.

When adding new mailfilters now the output isn't getting printed correctly. The \n isn't getting output correctly. Here's a sample:

### BEGIN FILTER_ID:35\n\n`test -e \"$DEFAULT/.Other\" && exit 1 || exit 0`\nif ( $RETURNCODE != 1 )\n{\n `maildirmake -f \"Other\" $DEFAULT`\n `chmod -R 0700 \"$DEFAULT/.Other\"`\n `echo \"INBOX.Other\" >> $DEFAULT/courierimapsubscribed`\n}\nif (/^Subject:.*WhoRU/:h)\n{\nexception {\nID35EndFolder = \"$DEFAULT/.Other/\"\nto $ID35EndFolder\n}\n}\n### END FILTER_ID:35\n

As you can see... it's all on one line, which means that deleting the filter via the web page deletes it from the mail_user_filter table, but not the mail_user table. Naturally, it also outputs into the .mailfilter file like this, making it break.

Just to be clear... it's not only showing up in the .mailfilter file as listed above. It's also showing up in the mail_user table the same way. It seems as if there is a problem in how the line gets put into the database, and this is what is causing it to be written incorrectly to the file.

Last edited by Rescue9; 17th September 2009 at 16:21. Reason: Clarification
Reply With Quote
Sponsored Links
  #2  
Old 17th September 2009, 11:24
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 35,777
Thanks: 821
Thanked 5,332 Times in 4,184 Posts
Default

Bugtracker:

http://bugtracker.ispconfig.org/inde...=905&project=3
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
The Following User Says Thank You to till For This Useful Post:
Rescue9 (17th September 2009)
  #3  
Old 17th September 2009, 17:37
Rescue9 Rescue9 is offline
Member
 
Join Date: Jun 2007
Posts: 52
Thanks: 4
Thanked 3 Times in 2 Posts
Default

WOW... fixed. So cool. Thanks! Now all that needs to be done is a release of 3.0.1.5
Reply With Quote
  #4  
Old 17th September 2009, 17:39
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 35,777
Thanks: 821
Thanked 5,332 Times in 4,184 Posts
Default

Or you get the changed files from svn.
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
  #5  
Old 17th September 2009, 17:51
Rescue9 Rescue9 is offline
Member
 
Join Date: Jun 2007
Posts: 52
Thanks: 4
Thanked 3 Times in 2 Posts
Default

True.... I've not played with svn a lot. How do I tell which changed files I need?

EDIT:
Nevermind... probably a bit more in depth than you want to go. :-P I'll Google.
I would like to ask something though. It would be really helpful if when you squashed a bug, you put what file was changed for the fix. This way we can look at the current file, the fixed file, and learn from it. This would help those of us who are trying to help squash bugs.

Last edited by Rescue9; 17th September 2009 at 18:10.
Reply With Quote
  #6  
Old 18th September 2009, 11:47
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 35,777
Thanks: 821
Thanked 5,332 Times in 4,184 Posts
Default

Quote:
It would be really helpful if when you squashed a bug, you put what file was changed for the fix. This way we can look at the current file, the fixed file, and learn from it. This would help those of us who are trying to help squash bugs.
We do this already in SVN. Download a SVN client of your choice e.g. tortoisesvn if you work on windows, then you can see in the SVN log which files had been changed and also which lines in which files had been modified to fix a bug.
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
  #7  
Old 18th September 2009, 15:04
Rescue9 Rescue9 is offline
Member
 
Join Date: Jun 2007
Posts: 52
Thanks: 4
Thanked 3 Times in 2 Posts
Default

Thanks Till. I just downloaded tortoisesvn yesterday after I saw your post, but am still learning how it works. I didn't realize that everything works from explorer... definitely different from working with svn from linux console.
Reply With Quote
  #8  
Old 18th September 2009, 15:08
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 35,777
Thanks: 821
Thanked 5,332 Times in 4,184 Posts
Default

The staps are:

1) Create a new empty folder in explorer.
2) make a right click and choose "SVN Checkout". Enter the svn URL:

svn://svn.ispconfig.org/ispconfig3/trunk/

3) After the checkuot, make a right click on the folder and choose "Tortoisesvn > show log" to open the log viewer. From time to time you should run update to keep your svn version up to date.
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
  #9  
Old 18th September 2009, 15:34
Rescue9 Rescue9 is offline
Member
 
Join Date: Jun 2007
Posts: 52
Thanks: 4
Thanked 3 Times in 2 Posts
Default

Ok... got that. I'm slowly figuring it out.

Still have a couple of questions though.
1) I posted my last bugfix to flyspray and you actually made the changes. Is it ok for me to make the changes directly to the SVN next time, or what would be the preferred method?

2) Is it ok if I make some minor changes to the doc files so that I can get the hang of working with SVN prior to making live changes on functional files?

Thanks a lot for your help.I've wanted to help this project for some time, but didn't know how.
Reply With Quote
  #10  
Old 19th September 2009, 10:43
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 35,777
Thanks: 821
Thanked 5,332 Times in 4,184 Posts
 
Default

1) Yes.
2) Yes.

If you dont have a svn login yet, please send a email to dev [at] ispconfig [dot] org
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
Reply

Bookmarks

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Installation fails on bad PHP sergio.morales Installation/Configuration 10 14th June 2008 11:11
Mail forward fails. Kaj Installation/Configuration 13 29th May 2008 16:57
ProFTP & MySQL: prftpd fails to start hecticking HOWTO-Related Questions 3 26th August 2007 22:31
Installation of 2.2.15 fails at compiling clamav xrat Installation/Configuration 0 24th July 2007 22:49
Installation fails on Ubuntu 6.06 Jcorrea920 Installation/Configuration 2 23rd April 2007 20:14


All times are GMT +2. The time now is 08:42.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2014, vBulletin Solutions, Inc.