Mailuser interface

[SpeedyB]

Originally Posted by Horfic

Solution:
When a client gets created, the sysuser get automatically added to the system.
So this sysuser has now a associated client and the error won't appear.

1.)So the best way, would be to just create the missing client for the sysuser.

Dear Horfic,

THis is not the case in my situation.

I have several clients, and all clients have 2 sysusers (Why only have one admin for an environment??)
When I have 5 clients I have 10 sys users....

The piece of code you run:

$client->mail_spamfilter_user_update($session_id, $id, $mail_user[0]['sys_userid'], $params);

requires the following entries:
Sessionid,
MailboxID
ClientID,
Parameters

Since the code requests an clientid and you use the sys_userid this is where the problem starts. I haven't searched if one of the mailbox poperties is the clientid, but otherwise it might be possible to get the clientid form the sysuser properties?

regards,

Bas Steelooper

[NeeChee]

Originally Posted by Horfic

PS: French translation is in the svn.

Yes I noticed, if you check the language section of my instructions, you'll see I've inventorized all languages and which parts of them are still missing or incomplete.

[Horfic]

@SpeedyB
You are totaly right with that, but the mail_user table only has the sysuser_id field, no client field, so there is no other way for the moment (except the second solution with the 0 I posted, so everything gets created by admin).

I would have to change a little bit in the remoting_lib.inc.php from ISPConfig 3. ATM you have to send the client_id, he is looking up if that client exists and then he looks for the appropriate sysuser and is using the fields of it (sys_username, sys_userid, sys_default_group, sys_groups).

It would be better if he is just looks up if the sysuser exists and is then using the fields, so that we skip the client lookup.

The modified loadUserProfile function in the /interface/lib/classes/remoting_lib.inc.php would be this.

PHP Code:

function loadUserProfile($client_id = 0) {
    global $app,$conf;
            
    $client_id = intval($client_id);
            
    if($client_id == 0) {
        $this->sys_username         = 'admin';
        $this->sys_userid            = 1;
        $this->sys_default_group     = 1;
        $this->sys_groups            = 1;
    } else {
        //* load system user
        $user = $app->db->queryOneRecord("SELECT * FROM sys_user WHERE sysuser_id = $client_id");
        if(empty($user["userid"])) {
            $this->errorMessage .= 'No sysuser with the ID $client_id found.';
            return false;
        }
        $this->sys_username         = $user['username'];
        $this->sys_userid            = $user['userid'];
        $this->sys_default_group     = $user['default_group'];
        $this->sys_groups             = $user['groups'];
    }
            
    return true;
            
} 


I don't know how much it would effect the other scripts which are using the remote framework, but I know that pretty much only the sysuser_id and not the client_id is in the tables.

So probably it helps the others too.

UPDATE: I updated the remote_lib.inc.php file in the ISPConfig 3 svn, so with the new version it will be fine^^

[NeeChee]

Originally Posted by Horfic

UPDATE: I updated the remote_lib.inc.php file in the ISPConfig 3 svn, so with the new version it will be fine^^

Did you get SVN access? Pretty awesome

[moglia]

Im just upgraded to SVN version and now any modifications on autoresponse and other says: "No sysuser with the ID $client_id found"

[NeeChee]

Originally Posted by moglia

Im just upgraded to SVN version and now any modifications on autoresponse and other says: "No sysuser with the ID $client_id found"

See post #133

[moglia]

Originally Posted by NeeChee

See post #133

Im using latest version from SVN.

[moglia]

I maked a debug info at console the remote script pass ID 2 to remote lib.
try make some SQL to investigate the situation:

mysql> select distinct(sys_userid) from mail_user;
+------------+
| sys_userid   | 
+------------+
|          2      |
+------------+

mysql> select sys_userid, client_id,contact_name,company_name from client;
+------------+-----------+------------------------+----------------------
| sys_userid   | client_id   | contact_name              | company_name         |
+------------+-----------+------------------------+----------------------
|          1      |         1     | Rodrigo Moglia              | INTERARIA IT           |
|          1      |         2     | Pierre                         | Pierre                      |
--------------------------------------------------------------------------

mysql> select userid, sys_userid, username from sys_user;
+--------+------------+--------------+
| userid | sys_userid | username          |
+--------+------------+--------------+
|      1    |          1      | admin           |
|      2    |          1      | interatius       |
|      3    |          1      | pierre        |
---------------------------------------

[NeeChee]

Originally Posted by moglia

Im using latest version from SVN.

Yes, but the patch was done in the ISPconfig3 SVN and not the plugin SVN since the patch had to be done in the ISPconfig3 Remote Framework. If you can't update your ISPconfig3 installation through SVN, try editing the file as described in post #133.

[moglia]

My translator of brazilian portuguese and use latest version SVN head on my prodution server.
No sysuser with the ID $client_id found persists i created another account as reseller or client
and the same results displayed.