Apache Directive errors

[bwragg]

Hi,

I've had a problem quite a few times with clients setting Apache Directives and wondered if anyone had a solution. What happens is a client can accidently make an error in an apache directive, save the changes and then ISPConfig tries to save it. When I check the ISPconfig log it does a check on the conf which fails so it automatically rolls back to the last working conf settings.

This is fantastic as apache keeps running, except the user doesn't know they have made a mistake and neither do I. I've even had it happen that days later changes I make aren't being saved, I check the logs and find that someone set a bad directive on another site days ago.

So I was just wondering if anyone knows a way to notify them or me that their is an error which a change they have just made?

Thanks,

bwragg

[till]

Take a look at the apache directive field, if a user enters there something wrong the apache directives get commented out to notice the user.

[bwragg]

thanks till. That woluld be great but I just checked this with the problem that the user had the other day. They entered a redirect but accidently had a new line after the directory like this:

Redirect 301 /email <new line here>
http://www.theirsite.com/their_directory

instead of

Redirect 301 /email http://www.theirsite.com/their_directory

the ispconfig log reports this when the above is saved:

16.03.2009 - 16:03:48 => WARN - /root/ispconfig/scripts/lib/config.lib.php, Line 2604: WARNING: could not httpd -t &> /dev/null
16.03.2009 - 16:03:48 => WARN - /root/ispconfig/scripts/lib/config.lib.php, Line 2616: httpd syntax seems to contain errors, reloading with old configuration
16.03.2009 - 16:03:48 => INFO - /root/ispconfig/scripts/lib/config.lib.php, Line 2617: mv -f /etc/httpd/conf/vhosts/Vhosts_ispconfig.conf /etc/httpd/conf/vhosts/Vhosts_ispconfig.conf_16-03-09_16-03-48
16.03.2009 - 16:03:48 => INFO - /root/ispconfig/scripts/lib/config.lib.php, Line 2618: mv -f /etc/httpd/conf/vhosts/Vhosts_ispconfig.conf~ /etc/httpd/conf/vhosts/Vhosts_ispconfig.conf

But when I go back into the directives box in the control panel it has the original setting uncommented. Any ideas?

[falko]

Originally Posted by bwragg

thanks till. That woluld be great but I just checked this with the problem that the user had the other day. They entered a redirect but accidently had a new line after the directory like this:

Redirect 301 /email <new line here>
http://www.theirsite.com/their_directory

instead of

Redirect 301 /email http://www.theirsite.com/their_directory

What does

httpd -t

show?

[bwragg]

It says

"Syntax OK"

.

When I add a dodgy directive it still says the same (because it rolls back to the last working configuration)

[till]

You have to check the file with the date appended and not the one that was rolled back. Run:

mv /etc/httpd/conf/vhosts/Vhosts_ispconfig.conf /etc/httpd/conf/vhosts/Vhosts_ispconfig.conf.bak
mv /etc/httpd/conf/vhosts/Vhosts_ispconfig.conf_16-03-09_16-03-48 /etc/httpd/conf/vhosts/Vhosts_ispconfig.conf

httpd -t

mv /etc/httpd/conf/vhosts/Vhosts_ispconfig.conf.bak /etc/httpd/conf/vhosts/Vhosts_ispconfig.conf

[bwragg]

Sorry Till, I thought Falko may have been checking I didn't have some other problem in the file.

When I do this as expected it complains about the directive I set in error:

Syntax error on line 27 of /etc/httpd/conf/vhosts/Vhosts_ispconfig.conf_25-03-09_07-46-27:
URL to redirect to is missing

Still its not #'ing out the lines in the directives box.

[falko]

Can you post line 27 of /etc/httpd/conf/vhost/Vhosts_ispconfig.conf_25-03-09_07-46-27?

[bwragg]

Sorry for the delay. Line 27 is the line I've already posted:

Line 27: Redirect 301 /email <new line here>
Line 28: http://www.theirsite.com/their_directory

[falko]

I guess the correct line should be

Redirect 301 /email http://www.theirsite.com/their_directory