Go Back   HowtoForge Forums | HowtoForge - Linux Howtos and Tutorials > ISPConfig 2 > Developers' Forum

Do you like HowtoForge? Please consider supporting us by becoming a subscriber.
Reply
 
Thread Tools Display Modes
  #1  
Old 19th November 2008, 00:27
karailiev karailiev is offline
Junior Member
 
Join Date: Jul 2008
Posts: 13
Thanks: 0
Thanked 0 Times in 0 Posts
Default New in ISPConfig development and have some questions

Hello all!
I'm new in the development team and have few questions.
I've assigned to myself a ticket about password strength indicator and I have it working. It's about 100 lines javascript and I'm wondering where to put it.
When I add it to interface\web\js\scrigo.js it's working fine, but I want to ask if this is the right place.
I also have to create new label "Password strength", so I added it to interface\web\client\lib\lang\en_client.lng
Should I edit other languages' files (de/it/fr/nl) or should I somehow inform the users who maintain them?
Reply With Quote
Sponsored Links
  #2  
Old 19th November 2008, 09:58
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 36,421
Thanks: 834
Thanked 5,500 Times in 4,329 Posts
Default

Quote:
When I add it to interface\web\js\scrigo.js it's working fine, but I want to ask if this is the right place.
Thats the right place.

Quote:
Should I edit other languages' files (de/it/fr/nl) or should I somehow inform the users who maintain them?
The best might be to add the english version to the other language files as well. But in case that a developer forgtets to add a string to all languages, it is not a problem as the language editor has a feature called "merge" to add missing strings from the english master language file to the other language files.
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
  #3  
Old 19th November 2008, 16:19
karailiev karailiev is offline
Junior Member
 
Join Date: Jul 2008
Posts: 13
Thanks: 0
Thanked 0 Times in 0 Posts
Default

Is there some way to use the translation files in javascript?
I have strings like "too short", "weak", "strong" and it would be nice to translate them to all available languages.
Reply With Quote
  #4  
Old 19th November 2008, 16:24
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 36,421
Thanks: 834
Thanked 5,500 Times in 4,329 Posts
Default

Thats not implemented yet. But it should not be a problem to deliver the javascript trough a php file and replace the language strings with the template engine used in ispconfig3.
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
  #5  
Old 21st November 2008, 12:05
karailiev karailiev is offline
Junior Member
 
Join Date: Jul 2008
Posts: 13
Thanks: 0
Thanked 0 Times in 0 Posts
Default

When I see a bug or feature that I can fix/implement should I do it or first have to report it in the bugtracker and wait to be confirmed?
Reply With Quote
  #6  
Old 21st November 2008, 13:30
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 36,421
Thanks: 834
Thanked 5,500 Times in 4,329 Posts
 
Default

Please report it in the bugtracker and assign it to yourself. You dont have to wait until it gets confirmed.
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
Reply

Bookmarks

Tags
javascript, languages, password

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +2. The time now is 15:41.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2014, vBulletin Solutions, Inc.