#1  
Old 19th September 2007, 09:47
msgilligan msgilligan is offline
Junior Member
 
Join Date: Aug 2007
Location: Santa Cruz, CA
Posts: 5
Thanks: 1
Thanked 1 Time in 1 Post
Default Remoting Framework Issues

I'm trying to use the Remoting Framework to migrate data from a proprietary Control Panel into ISPConfig 2.2.16

I'm having some problems which I'll provide more info on later.

For now, I have two questions and a patch:
1) Why has nusoap been renamed/consolidated in ispconfig_soap.obj.php?
2) Are there any reasons why nusoap can't be upgraded?
3) I found a problem with error handling on line 2000 of ispconfig_soap.obj.php. In some cases $method_response is a soap_fault and causes an error when PHP tries to convert it to a string in $this->debug(). I will attach a patch which fixes this problem, which makes it harder to get the real error info. I'm guessing this is a NuSoap bug that is fixed in later versions, but haven't looked.

I can put the patch in the bugtracker if that's a better place to put it.
Reply With Quote
Sponsored Links
  #2  
Old 19th September 2007, 09:56
msgilligan msgilligan is offline
Junior Member
 
Join Date: Aug 2007
Location: Santa Cruz, CA
Posts: 5
Thanks: 1
Thanked 1 Time in 1 Post
Default Patch for ispconfig_soap.obj.php

Fixes abort on soap_fault on line 2000.
(This perhaps could be fixed in a later version of NuSoap, but I haven't checked)
Attached Files
File Type: zip ispconfig_soap.patch.zip (516 Bytes, 383 views)
Reply With Quote
  #3  
Old 19th September 2007, 15:47
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 36,413
Thanks: 834
Thanked 5,498 Times in 4,328 Posts
Default

Quote:
Originally Posted by msgilligan
I'm trying to use the Remoting Framework to migrate data from a proprietary Control Panel into ISPConfig 2.2.16

I'm having some problems which I'll provide more info on later.

For now, I have two questions and a patch:
1) Why has nusoap been renamed/consolidated in ispconfig_soap.obj.php?
2) Are there any reasons why nusoap can't be upgraded?
3) I found a problem with error handling on line 2000 of ispconfig_soap.obj.php. In some cases $method_response is a soap_fault and causes an error when PHP tries to convert it to a string in $this->debug(). I will attach a patch which fixes this problem, which makes it harder to get the real error info. I'm guessing this is a NuSoap bug that is fixed in later versions, but haven't looked.

I can put the patch in the bugtracker if that's a better place to put it.
1) To fit the ISPConfig naming conventions. With the original name, the file caould not be lodaed with the ISPconfig class loader.
2) No.
3) Thanks for the fix. Do you have SVN access and may upload it directly to SVN?
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
The Following User Says Thank You to till For This Useful Post:
msgilligan (19th September 2007)
  #4  
Old 19th September 2007, 20:16
msgilligan msgilligan is offline
Junior Member
 
Join Date: Aug 2007
Location: Santa Cruz, CA
Posts: 5
Thanks: 1
Thanked 1 Time in 1 Post
Default SVN Commit of NuSoap Patch

I have read-only SVN access. If I had write access I would check it in. (It's sitting in my SVN sandbox right now.)

I'm also tempted to try to upgrade to the latest NuSOAP. I assume the way you combined the files into a single file was fairly straightforward and that there were no other changes, right?

I'm not sure what the risks are to ISPConfig Remoting from this upgrade. How widely used and/or tested is it?

The current version of NuSOAP is 0.7.2. Looking at the changelog, it looks like there are a lot of improvements and bug fixes since 0.6.3
Reply With Quote
  #5  
Old 21st September 2007, 19:47
msgilligan msgilligan is offline
Junior Member
 
Join Date: Aug 2007
Location: Santa Cruz, CA
Posts: 5
Thanks: 1
Thanked 1 Time in 1 Post
Default Patch checked in

The patched is checked in to the ISPConfig-2.3.2-dev branch as of SVN revision 828.
Reply With Quote
The Following User Says Thank You to msgilligan For This Useful Post:
till (21st September 2007)
  #6  
Old 21st September 2007, 20:35
msgilligan msgilligan is offline
Junior Member
 
Join Date: Aug 2007
Location: Santa Cruz, CA
Posts: 5
Thanks: 1
Thanked 1 Time in 1 Post
Default Upgrade to NuSOAP 0.7.2?

If I take the latest version of NuSOAP and put it into a single PHP file so it works with the "classloader", and test it with my limited remoting code on Fedora Core 6, what kind of testing is needed before it could be checked into the 2.3.2-dev branch?

Are there any other issues?
Reply With Quote
  #7  
Old 21st September 2007, 22:07
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 36,413
Thanks: 834
Thanked 5,498 Times in 4,328 Posts
 
Default

I think if it works with one of the remoting functions, all functions shall work as they all use the same nusopa functions.
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
Reply

Bookmarks

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Adding a Web Remoting Framework bigger_travis General 1 13th July 2007 20:26
Remoting framework released as OpenSource till Developers' Forum 4 28th March 2007 16:08
Remoting framework still show black block under tools mxc Installation/Configuration 2 26th February 2007 07:13
Remoting Framework mlz General 9 18th January 2007 22:52
joomla remoting framework plugin mxc Developers' Forum 1 21st August 2006 16:49


All times are GMT +2. The time now is 11:42.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2014, vBulletin Solutions, Inc.