Multiple IPs running SSL: config error

[benbalbo]

I just had problems getting a new certificate to work, and noticed that the Vhosts_ispconfig.conf had:

NameVirtualHost 192.168.0.50:80
NameVirtualHost 192.168.0.51:80
NameVirtualHost 192.168.0.52:80

But the SSL port (443) had no NameVirtualHost entries.

I greped the source to find any occurances of NameVirtualHost and only found it in one place. I've tried to fix this by changing /root/ispconfig/scripts/lib/config.lib.php at line 1230 from:

        $mod->tpl->assign( array(SERVERIP => "NameVirtualHost ".$ip["server_ip"].$web_port));

to:

        $mod->tpl->assign( array(SERVERIP => "NameVirtualHost ".$ip["server_ip"].$web_port),
                           array(SERVERIP => "NameVirtualHost ".$ip["server_ip"].$ssl_port));

But this hasn't solved the problem.

I'm going to delve into the template class now to see if I can see how it works and what I need to do to fix this issue. Any tips, pointers, advice, existing patches would be very welcome :-)

Thanks!
BB