#1  
Old 7th December 2011, 08:28
nveid nveid is offline
Member
 
Join Date: Jan 2006
Location: Daytona Beach, FL
Posts: 87
Thanks: 7
Thanked 17 Times in 14 Posts
Send a message via Yahoo to nveid Send a message via Skype™ to nveid
Default db_mysql.inc.php

So.. I'm working on the mysqli_* conversion of the mysql_* code, while i started on the one in /server/lib/classes.. I all of sudden thought to do a diff wondering how the vanilla one before I touched it is similar to the one in /interface/lib/classes My diff is misleading, the files are only slightly different.

For example.. The one in /interface uses php5 class methods using private/public declarations, while the one in /server uses php4 class declarations var.. Anywho, aside for those small differences.. Figured possibly if I ask this one blank question..

Do both these files suppose to be exactly the same just placed in different locations? Either way, I'm doing a line by line diff.. But any tips are welcomed.
__________________
-- RLB

Last edited by nveid; 7th December 2011 at 09:24.
Reply With Quote
Sponsored Links
  #2  
Old 7th December 2011, 10:43
nveid nveid is offline
Member
 
Join Date: Jan 2006
Location: Daytona Beach, FL
Posts: 87
Thanks: 7
Thanked 17 Times in 14 Posts
Send a message via Yahoo to nveid Send a message via Skype™ to nveid
Default

I've pushed the new db_mysql.inc.php's to the repo.. Devs please test it out & see if its causes any problems.
__________________
-- RLB
Reply With Quote
The Following User Says Thank You to nveid For This Useful Post:
till (7th December 2011)
  #3  
Old 7th December 2011, 10:52
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 36,733
Thanks: 840
Thanked 5,596 Times in 4,407 Posts
Default

Quote:
Do both these files suppose to be exactly the same just placed in different locations? Either way, I'm doing a line by line diff.. But any tips are welcomed.
Both files were the same at the beginning, but they had been developed differently as the inteface needed some additional functions. But I guess that the version from the interface should work for the server as well, but not the other way round.
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
  #4  
Old 7th December 2011, 11:00
nveid nveid is offline
Member
 
Join Date: Jan 2006
Location: Daytona Beach, FL
Posts: 87
Thanks: 7
Thanked 17 Times in 14 Posts
Send a message via Yahoo to nveid Send a message via Skype™ to nveid
 
Default

I standardized them both to be similar and the same again.. the only difference now should be the show_error_messages variable.

For server this now should be set to false. Indicating that it will log its errors, while interface side this is set to true indicating that errors will be 'echo'ed.
__________________
-- RLB
Reply With Quote
The Following User Says Thank You to nveid For This Useful Post:
till (7th December 2011)
Reply

Bookmarks

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +2. The time now is 12:56.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2014, vBulletin Solutions, Inc.