#1  
Old 25th April 2006, 15:23
oliver.blaha oliver.blaha is offline
Member
 
Join Date: Apr 2006
Posts: 37
Thanks: 0
Thanked 1 Time in 1 Post
Default PHP handling

Hi,

I'm not completely happy about how PHP is enabled/disabled in Vhosts.
IMHO completely disabling PHP for the whole server and only activating it in the vhost statements isn't the best practice.

I've enhanced the apache2_php parameters in config.inc.php with "engine". If you specify this option, an "php_admin_flag on" or "php_admin_flag off" is included in the vhost. This way it is possible to let PHP be activated for the server, without enabling it for every vhost.

From now on you can either use the old format:

Code:
$go_info["server"]["apache2_php"] = 'both';
Or you can pass an array of valid options:

Code:
$go_info["server"]["apache2_php"] = array("filter", "engine");
It should be completely backward compatible.

If you like this way of handling PHP, I'd suggest to:

1) Change the default value to:
Code:
$go_info["server"]["apache2_php"] = array("filter", "addtype", "engine");
2) Remove the commenting of the php AddType clauses in httpd.conf.

This would decrease the amount of configuration when setting up a new server, as you can leave the mime types and the php AddTypes untouched.
Reply With Quote
Sponsored Links
  #2  
Old 25th April 2006, 21:39
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 36,400
Thanks: 834
Thanked 5,492 Times in 4,323 Posts
Default

Hi Oliver,

looks fine and sounds reasonable.

I'am not sure which notation we shall use in the config.inc.php file, as this file will be edited by poeple not familar with PHP and the PHP array syntax.

Option 1) as you suggested:

Quote:
$go_info["server"]["apache2_php"] = array("filter", "addtype", "engine");
Or option 2)

Quote:
$go_info["server"]["apache2_php"] = "filter,addtype,engine";
What do you think?
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
  #3  
Old 25th April 2006, 23:48
oliver.blaha oliver.blaha is offline
Member
 
Join Date: Apr 2006
Posts: 37
Thanks: 0
Thanked 1 Time in 1 Post
Default

Hm, I suggest we simply support both *g*

Currently I'm checking if it is an array, and if it's not, I assign it as the only element of a new array.

If we simply replace this assignment by an explode(",", ...) we'd magically support single options, strings with comma seperated options AND arrays.
Reply With Quote
  #4  
Old 26th April 2006, 00:13
oliver.blaha oliver.blaha is offline
Member
 
Join Date: Apr 2006
Posts: 37
Thanks: 0
Thanked 1 Time in 1 Post
Default

Update: As it was a quite trivial change, I simply checked it in with explode. Hope you like it. I changed this for the MySQL priviledges which are changed by the MySQL Quota script, too.
Reply With Quote
  #5  
Old 26th April 2006, 09:19
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 36,400
Thanks: 834
Thanked 5,492 Times in 4,323 Posts
 
Default

Fine, thanks. It might be easier for the users if they might use comma separated values
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
Reply

Bookmarks

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
"unknown filter" growing apache log. wwparrish Installation/Configuration 6 1st September 2006 18:40
Questions in regards to ISP-Server Setup - Ubuntu 5.10 "Breezy Badger" rbrantley HOWTO-Related Questions 16 10th April 2006 18:26
Downgrade php5 to php4.4.2 llizards Installation/Configuration 4 13th March 2006 23:58
all my site go to /var/www/ Absolusteph Installation/Configuration 14 11th March 2006 21:27
Can not access website after uploading brianetilley Installation/Configuration 21 11th January 2006 19:43


All times are GMT +2. The time now is 14:13.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2014, vBulletin Solutions, Inc.