
29th May 2010, 16:01
|
|
Senior Member
|
|
Join Date: Apr 2006
Location: Sydney
Posts: 278
Thanks: 0
Thanked 12 Times in 10 Posts
|
|
Quote:
Originally Posted by till
That depends on how you work with a open source project. mike_p for example works actively with the ispconfig project and commits his changes and fixes back to the source tree. You decided to work only on your own without contributing to the ispconfig project, so your chnages does not go into the ispconfig sources and thats why you have ptoblems with overwritten files.
|
Well my work doesn't involve changing ispc3, hence why i only created the theme in a way which doesn't require making changes to ispc3 code and only the postfix main.cf i had issues because i have changes I needed, nothing wrong with that and that's not part of ispc3.
The same with my awstats plugin, it's a plugin which doesn't interfere with ispc3. So I really don't get your point.
I like to throw changes and ideas into the air and those who want to catch it can, if someone wants to take my idea and improve on it, then even better. I try what i can for the community with the little time i have. That's why if you check my theme code you'll notice it's not 100% themed and only the main parts and a lot of missing icons.
|

29th May 2010, 16:12
|
|
Super Moderator
|
|
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 32,076
Thanks: 697
Thanked 4,254 Times in 3,265 Posts
|
|
But then I dont understand your complaint:
Quote:
Yeah that would be ideal method really but since the ispconfig3 upgrades are a little brutal and overwrite almost everything you changed, you have to keep backup copies and diff them in case they've added something to the page which a backup&restoring of your modified file would restore back to the old copy.
So i did it my way only for easy upgrade reasons only.
Would be nice if the ispc team styled everything a little better.
|
Custom themes never get overwritten. The only things that get overwritten are ispconfig core files. But you can not improve a software if you do not change the core sources. And changed source files have to be written on a update.
For customisations, ispconfig has a lot of areas which dont get ovewritten:
- Custom Theme files
- Custom Server configuration file templates
- Server plugins
- The event based interface plugins.
|

29th May 2010, 22:50
|
|
Senior Member
|
|
Join Date: Mar 2010
Location: Surrey, England
Posts: 140
Thanks: 9
Thanked 28 Times in 17 Posts
|
|
the following have been changed and committed to svn
8 x module.conf.php
1 x default theme sidenav.tpl.htm
1 x default theme nav_side.css
so have also fixed bug FS#1200 in the process.
- so hopefully this change can be moved forward to v3.0.2.2
|
|
The Following 3 Users Say Thank You to mike_p For This Useful Post:
|
falko (31st May 2010),
till (30th May 2010),
vogelor (5th June 2010)
|

18th June 2010, 22:06
|
|
HowtoForge Supporter
|
|
Join Date: Nov 2006
Posts: 207
Thanks: 17
Thanked 3 Times in 3 Posts
|
|
Quote:
Originally Posted by till
But then I dont understand your complaint:
Custom themes never get overwritten. The only things that get overwritten are ispconfig core files. But you can not improve a software if you do not change the core sources. And changed source files have to be written on a update.
For customisations, ispconfig has a lot of areas which dont get ovewritten:
- Custom Theme files
- Custom Server configuration file templates
- Server plugins
- The event based interface plugins.
|
Just one question I was working on some little customizing myself nothing big,
I have just copied the default theme Dir. and added my own logo and favicon.
(of course left the powered by ispconfig were it is I am proud to use it)
So if I name this Dir, mytheme and put this beside the default one It won't get deleted upon a update.
__________________
Updating my server to Debian Squeeze, so here I go again...
|

19th June 2010, 17:06
|
|
ISPConfig Developer
|
|
Join Date: Jan 2007
Location: Wernau, Germany
Posts: 219
Thanks: 42
Thanked 34 Times in 24 Posts
|
|
Quote:
Originally Posted by DaRKNeSS666NL
So if I name this Dir, mytheme and put this beside the default one It won't get deleted upon a update.
|
this is how i do it.
(just to know: the SVN- Version changes the template-handling, so that you only have to save the files, you change and not all files of the default-template - BUT DO NOT USE SVN IN PRODUCTION SYSTEMS!)
Olli
|

5th October 2010, 14:13
|
|
Member
|
|
Join Date: Aug 2010
Posts: 73
Thanks: 1
Thanked 2 Times in 2 Posts
|
|
I created my own theme by copying the default theme dir. and made some changes as well...
When I select for my users the new template on both Client and System area the changes don't get effect when I login with them.
Does anyone know if there's some kind of problem or a step I'm missing?
Last edited by bruno_floyd; 5th October 2010 at 14:23.
|

5th October 2010, 14:24
|
|
ISPConfig Developer
|
|
Join Date: Jan 2007
Location: Wernau, Germany
Posts: 219
Thanks: 42
Thanked 34 Times in 24 Posts
|
|
Quote:
Originally Posted by bruno_floyd
Does anyone know if there's some kind of problem or a step I'm missing?
|
this is the way it should work.
1) change the template for the user
2) logout and login as user
there is nothing more to do.
maybe you can create a account for me and tell me the login-data (as PM!) then i will try to test it..
Olli
|

5th October 2010, 15:51
|
|
Member
|
|
Join Date: Aug 2010
Posts: 73
Thanks: 1
Thanked 2 Times in 2 Posts
|
|
I did that... I created my new dir. and changed some colors on the side menu css.
Changed the template on both System and Client... checked if it updated on the DB and its ok.
When I use Firebug to view the css of the side menu, the original default color stills there, because the path to the css continues on the default, not the one I created.
Where on the code is the template set for the user?
I'd love vogelor, but my ISP is not available for external access yet... thanks!
|

5th October 2010, 16:03
|
|
ISPConfig Developer
|
|
Join Date: Jan 2007
Location: Wernau, Germany
Posts: 219
Thanks: 42
Thanked 34 Times in 24 Posts
|
|
send me a PM with your email.
i will help you!
you are not alone ;-)
|

5th October 2010, 16:43
|
|
Member
|
|
Join Date: Aug 2010
Posts: 73
Thanks: 1
Thanked 2 Times in 2 Posts
|
|
Sent there vogelor!
Thanks!
|
| Thread Tools |
|
|
| Display Modes |
Linear Mode
|
Posting Rules
|
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
HTML code is Off
|
|
|
All times are GMT +2. The time now is 15:37.
|
|
Recent comments
9 hours 27 min ago
14 hours 19 min ago
23 hours 12 min ago
1 day 11 min ago
1 day 3 hours ago
1 day 5 hours ago
1 day 8 hours ago
1 day 16 hours ago
2 days 57 min ago
2 days 2 hours ago