Go Back   HowtoForge Forums | HowtoForge - Linux Howtos and Tutorials > ISPConfig 3 > Developers' Forum

Do you like HowtoForge? Please consider supporting us by becoming a subscriber.
Reply
 
Thread Tools Display Modes
  #1  
Old 22nd June 2012, 13:50
cfoe cfoe is offline
ISPConfig Developer
 
Join Date: Oct 2011
Location: NRW, Germany
Posts: 233
Thanks: 27
Thanked 57 Times in 32 Posts
Send a message via Skype™ to cfoe
Default Streamlining vars for titles and descriptions

How about equalizing tmpl_vars for title and description in all templates?

In *_edit.htm files (and the associated lang files) titles and descriptions are combined in <tmpl_var name="form_hint">
In *_list.htm titles are "list_head_txt" and descriptions are "list_desc_txt"

I would propose to change all sites to titles ="list_head_txt" and descriptions = "list_desc_txt"

If you give me the go-ahead I will do the work and commit it to SVN.
__________________
Christian Foellmann

OpenSource-Projects - GitHub-Projects - SVN-Mirrors on GitHub - Foe Services
Reply With Quote
Sponsored Links
  #2  
Old 5th July 2012, 00:55
cfoe cfoe is offline
ISPConfig Developer
 
Join Date: Oct 2011
Location: NRW, Germany
Posts: 233
Thanks: 27
Thanked 57 Times in 32 Posts
Send a message via Skype™ to cfoe
Default

As I extended my theme for 3.0.5 today I found this in interface/web/mailuser/templates/index.htm

Code:
<h2><tmpl_var name="page_head_txt"></h2>
<p><tmpl_var name="page_desc_txt"></p>
I do not see why we should not use the tmpl_var named "page_*_txt" in ALL template files.

If I missing something tell me please
__________________
Christian Foellmann

OpenSource-Projects - GitHub-Projects - SVN-Mirrors on GitHub - Foe Services
Reply With Quote
  #3  
Old 5th July 2012, 02:21
cfoe cfoe is offline
ISPConfig Developer
 
Join Date: Oct 2011
Location: NRW, Germany
Posts: 233
Thanks: 27
Thanked 57 Times in 32 Posts
Send a message via Skype™ to cfoe
Default

Some related question:

Is there a difference? In template files.
PHP Code:
<tmpl_var name='btn_cancel_txt'>
{
tmpl_var name='btn_cancel_txt'
__________________
Christian Foellmann

OpenSource-Projects - GitHub-Projects - SVN-Mirrors on GitHub - Foe Services
Reply With Quote
  #4  
Old 5th July 2012, 09:15
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 34,555
Thanks: 791
Thanked 4,977 Times in 3,899 Posts
Default

There is no differnce, the templating system supports {...} as well as <...> for variable placeholders.
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
  #5  
Old 5th July 2012, 09:29
cfoe cfoe is offline
ISPConfig Developer
 
Join Date: Oct 2011
Location: NRW, Germany
Posts: 233
Thanks: 27
Thanked 57 Times in 32 Posts
Send a message via Skype™ to cfoe
Default

What do you say to my previous post?

I committed a lot of clean up tonight (couldnt sleep). Would be "no problem" to change the vars for title and description.
__________________
Christian Foellmann

OpenSource-Projects - GitHub-Projects - SVN-Mirrors on GitHub - Foe Services
Reply With Quote
  #6  
Old 5th July 2012, 09:36
till till is offline
Super Moderator
 
Join Date: Apr 2005
Location: Lüneburg, Germany
Posts: 34,555
Thanks: 791
Thanked 4,977 Times in 3,899 Posts
Default

The problem with this change is that it renders all translations invalid as the variable names of the texts are in the language files. mayn companys use their own language file sets which are not part of ISPConfig and we would break all their setups with the 3.0.5 update when we replace the current variable names with new ones.

I think cleaning up is good but we can do this only if it will not break the installed systems. So we should use the new naming for new files only and levae the current files as they are.
__________________
Till Brehm
--
Get ISPConfig support and the ISPConfig 3 manual from ispconfig.org.
Reply With Quote
Reply

Bookmarks

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT +2. The time now is 06:49.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2014, vBulletin Solutions, Inc.